“No Duh,” say senior developers everywhere.
The article explains that vibe code often is close, but not quite, functional, requiring developers to go in and find where the problems are - resulting in a net slowdown of development rather than productivity gains.
Devs are more invested in code they wrote themselves. When I’m writing tests for something I didn’t write, I’m less personally invested in it. Looking at PRs by other devs when we do pushes for improving coverage, I’m not alone here. That’s just human psychology, you care more about things you built than things you didn’t.
I think testing should be an integral part of the dev process. I don’t think any code should be merged until there are tests proving its correctness. Having someone else write the tests encourages handing tests to jr devs since they’re “lower priority.”
This, I think, is a very bad part of the problem and shouldn’t be happening regardless
It shouldn’t, but it does. The person who writes the code cares more about its correctness, so I trust them to write better tests.
I absolutely don’t. Since we’re talking about bad cases anyway, I don’t trust a developer to be diligent in finding bugs in their code more than I believe they will try to make all the tests pass. And it’s easier and better for the ego to achieve that if you write shit tests that only cover cases that you know will work.
Unit tests aren’t intended to find bugs, they’re intended to prove correctness. There should be a separate QA process for finding bugs, which involves integration testing. When QA inevitably finds a bug, the unit tests get updated with that case (and any similar cases).
And that’s what code reviews are for. If your tests don’t sufficiently cover the logic, the change should be rejected until they do. It’s a lot easier to verify the tests cover the logic if the tests are submitted w/ the logic changes.